Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Red Comrades Engine - DO NOT MERGE #1823

Open
wants to merge 136 commits into
base: master
from

Conversation

@whiterandrek
Copy link
Member

commented Aug 25, 2019

This PR adds support for the Red Comrades 1, Red Comrades 2 and Red Comrades Demo by S.K.I.F
The demo is fully supported.
The other games can run, but are unplayable due to a lot of bugs.

The engine misses walking system implementation. This is the main reason why the engine is bugged.

I'm not sure if it should be merged in current state.
Looking forward to your suggestions.

@whiterandrek whiterandrek force-pushed the whiterandrek:petka branch 3 times, most recently from e0ef358 to 072c254 Aug 25, 2019

@whiterandrek whiterandrek force-pushed the whiterandrek:petka branch from 072c254 to d0551ad Aug 25, 2019

op = (*_ip >> 24);
} while (op != 2);
unk = 1;
goto label;

This comment has been minimized.

Copy link
@bluegr

bluegr Aug 31, 2019

Member

This resets unk to 1, like in the beginning of the function. So here you can just call sub40B670(arg) instead of using goto

_bgs[i].attachedObjIds.resize(stream->readUint32LE());
for (uint j = 0; j < _bgs[i].attachedObjIds.size(); ++j) {
_bgs[i].attachedObjIds[j] = stream->readUint16LE();
QMessageObject *obj = g_vm->getQSystem()->findObject(_bgs[i].attachedObjIds[j]);

This comment has been minimized.

Copy link
@bluegr

bluegr Aug 31, 2019

Member

You are using g_vm->getQSystem() a lot in this class. You could store a pointer to it in a class variable instead

@@ -0,0 +1,3 @@
# This file is included from the main "configure" script
# add_engine [name] [desc] [build-by-default] [subengines] [base games] [deps]
add_engine petka "Red Comrades" no "" "" "highres"

This comment has been minimized.

Copy link
@ccawley2011

ccawley2011 Aug 31, 2019

Member
Suggested change
add_engine petka "Red Comrades" no "" "" "highres"
add_engine petka "Red Comrades" no "" "" "highres 16bit"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.