Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MADE: Add Manhole detect and separate out detections list #1829

Merged
merged 2 commits into from Sep 2, 2019

Conversation

@dafioram
Copy link
Member

commented Sep 2, 2019

  1. Add an unstable manhole version (gog)
  2. Move MADE detection list into separate file.

I tested the changes by running return to zork.

@bluegr

This comment has been minimized.

Copy link
Member

commented Sep 2, 2019

The Masterpiece Edition is not based on the MADE engine, but on another, HyperCard-like engine:
https://wiki.scummvm.org/index.php/The_Manhole

Thus, please do not add this version in this engine

@dafioram

This comment has been minimized.

Copy link
Member Author

commented Sep 2, 2019

scummvm autodetected this as MADE based on the dat file, is there a good way to inform the user that this version shouldn't be added as I have done? I imagine someone in the future will do the same as I have done.

@bluegr

This comment has been minimized.

Copy link
Member

commented Sep 2, 2019

You can comment this version out, and add a comment that it's not supported, since it's not using the MADE engine. This way, people won't try to re-add it

MADE: Note that GOG manhole game is not MADE
Comment it out in the detection tables.

@dafioram dafioram force-pushed the dafioram:madeDetect branch from 92d84e2 to d47070b Sep 2, 2019

@dafioram

This comment has been minimized.

Copy link
Member Author

commented Sep 2, 2019

How that look?

@bluegr

This comment has been minimized.

Copy link
Member

commented Sep 2, 2019

Looks good, thanks! :) Merging

@bluegr bluegr merged commit 717d7ad into scummvm:master Sep 2, 2019

2 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.