Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PSP: Replace PSPSaveFileManager with DefaultSaveFileManager #1834

Merged
merged 1 commit into from Sep 6, 2019

Conversation

@ccawley2011
Copy link
Member

commented Sep 6, 2019

The PSP save file manager isn't needed after commits 04c57ba and 196b33b.

@ccawley2011 ccawley2011 requested a review from rsn8887 Sep 6, 2019

@sev-

This comment has been minimized.

Copy link
Member

commented Sep 6, 2019

Great, thanks!

@sev- sev- merged commit 7a8ddcb into scummvm:master Sep 6, 2019

2 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ccawley2011 ccawley2011 deleted the ccawley2011:psp-saves branch Sep 6, 2019

@sev-

This comment has been minimized.

Copy link
Member

commented Sep 6, 2019

oops. you requested review. and I am too hasty. Hope @rsn8887 is not complaining, but if you do, feel free to revert

@rsn8887

This comment has been minimized.

Copy link
Contributor

commented Sep 7, 2019

@ccawley2011 and I discussed a similar change for the Switch platform on Discord a while ago iirc and we agreed that this is fine. It is more or less a refactoring that doesn’t change functionality.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.