Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GUI: Fix launcher layout for small widths #1873

Merged
merged 1 commit into from Oct 17, 2019

Conversation

@bgK
Copy link
Member

commented Oct 2, 2019

  • Testing if a widget can be centered was ignoring the padding.
  • Only resize a layout based on its content if it was not explicitly
    sized by its parent. Fixes the logo causing incorrect layout
    computations when the window width is lower than the image width.

Before:
Capture d’écran de 2019-10-02 19-32-52

After:
Capture d’écran de 2019-10-02 19-31-06

There are very obvious remaining issues (I have a fix for the wrapping logo planned for another PR), but at least the layout is correct.

* Testing if a widget can be centered was ignoring the padding.
* Only resize a layout based on its content if it was not explicitely
   sized by its parent. Fixes the logo causing incorrect layout
   computations when the window width is lower than the image width.
@sev-

This comment has been minimized.

Copy link
Member

commented Oct 2, 2019

Nice catch, though I think, that for such low resolution the more practical approach would be landscape. (Still, the issue would remain, I know).

I'll take a deeper look in couple of days.

@bgK

This comment has been minimized.

Copy link
Member Author

commented Oct 13, 2019

I will merge this in a few days unless there are further comments.

@bgK bgK merged commit 1dce33d into scummvm:master Oct 17, 2019
2 checks passed
2 checks passed
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.