Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CREATE_PROJECT: Split non engine code into additional projects #1876

Open
wants to merge 7 commits into
base: master
from

Conversation

@henke37
Copy link
Contributor

commented Oct 3, 2019

This moves code files out from the main scummvm project and into new projects.

Specifically, it uses these new projects:

  • Audio
  • Graphics
  • Video
  • Common
  • Backend
  • Gui
@dreammaster

This comment has been minimized.

Copy link
Member

commented Oct 4, 2019

I verified that the new Visual Studio solution builds and runs fine. Though little nitpick.. it'd be preferable if they were all grouped under a single solution folder, rather than just being intermixed with the engine projects.

@henke37

This comment has been minimized.

Copy link
Contributor Author

commented Oct 4, 2019

Good point. I will look into that.

@sluicebox

This comment has been minimized.

Copy link
Member

commented Oct 4, 2019

What's the motivation?

There's some good code cleanup in here but I don't know why the scummvm project should be broken up.

I like the simplicity of one-engine-per-project + the-app. When I'm in sci mode I want to just see scummvm and sci projects. I frequently scope my VS searches to Current Project on scummvm when I want everything but engines. I specifically want those searches to touch graphics/backend/etc because I don't know ahead of time where they'll hit, that's why I run them in the first place! =) Why break up the mandatory project into equally mandatory projects? It's not like "graphics" is optional.

I found the existing project structure representative of the modular relationships when I was learning, extra hierarchy would have made it less clear. Now some projects map to plugins but some don't?

@dreammaster

This comment has been minimized.

Copy link
Member

commented Oct 4, 2019

Whilst I can't speak for Henke37, I could see two potential benefits from this:

  1. Quicker compiles. When I do pulls that changes things in the ScummVM project, Visual Studio has the habit of doing a full rebuild of it. By splitting things up into separate sub-projects, it should be more insulated against this happening. Though.. it could also have been due to my frequent regeneration of the solution. The recent commit to create_project to not regenerate version.h may have already ameliorated this.. I'm not sure.

  2. I too frequently use "Current Project" for searches when I'm searching for things within the ScummVM project. But despite this, I normally am only interested in finding things within a specific area. This may prove helpful with that, rather than having to select specific folders to search in, so the searches are limited to just "common/" for example.

Over all, I'm on the fence about this pull request, so long as they (the sub-projects) were grouped in a single ScummVM solution folder. The important thing, in my mind, is if having them as separate projects will help improve recompilation speed. If not, and there's not something I'm missing beyond the slight benefit to doing area specific searches, then it may not be worth splitting them up.

@henke37

This comment has been minimized.

Copy link
Contributor Author

commented Oct 4, 2019

One thing for sure, I definitely broke the other code generators. And I'm not equipped to fix them. This is not getting merged without help from others.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.