Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
CREATE_PROJECT: Split non engine code into additional projects #1876
What's the motivation?
There's some good code cleanup in here but I don't know why the scummvm project should be broken up.
I like the simplicity of one-engine-per-project + the-app. When I'm in sci mode I want to just see scummvm and sci projects. I frequently scope my VS searches to Current Project on scummvm when I want everything but engines. I specifically want those searches to touch graphics/backend/etc because I don't know ahead of time where they'll hit, that's why I run them in the first place! =) Why break up the mandatory project into equally mandatory projects? It's not like "graphics" is optional.
I found the existing project structure representative of the modular relationships when I was learning, extra hierarchy would have made it less clear. Now some projects map to plugins but some don't?
Whilst I can't speak for Henke37, I could see two potential benefits from this:
Over all, I'm on the fence about this pull request, so long as they (the sub-projects) were grouped in a single ScummVM solution folder. The important thing, in my mind, is if having them as separate projects will help improve recompilation speed. If not, and there's not something I'm missing beyond the slight benefit to doing area specific searches, then it may not be worth splitting them up.