Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AMIGAOS4: Fix NULL pointer access on using plugins #1877

Merged
merged 4 commits into from Oct 8, 2019

Conversation

@raziel-
Copy link
Contributor

commented Oct 7, 2019

We need to explicitely open dos.library and it's IDOS interface.
Otherwise we will hit an IDOS NULL pointer after compiling a shared binary with (shared) plugins.
The hit will happen on loading a game from any engine, if more than one engine/plugin is available.

raziel- added 2 commits Oct 7, 2019
raziel- added 2 commits Oct 8, 2019
@bluegr

This comment has been minimized.

Copy link
Member

commented Oct 8, 2019

Looks good now, thanks! Merging

@bluegr bluegr merged commit 3d60bee into scummvm:master Oct 8, 2019
2 checks passed
2 checks passed
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@raziel- raziel- deleted the raziel-:patch-1 branch Oct 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.