Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TTS: Enable in Mingw-w64 builds #1881

Merged
merged 1 commit into from Oct 10, 2019

Conversation

@sluicebox
Copy link
Member

commented Oct 9, 2019

This PR gets Text To Speech working in default Mingw-w64 environments.

  • Removes reference to sapiddk.h which isn't used and isn't in Mingw-w64
  • Defines guids whose symbols are missing from Mingw-w64
  • Restores TTS detection to configure script

With these changes, TTS works out of the box in Mingw-w64 environments. Mingw32 doesn't include speech api headers or libraries and so configure still correctly detects that TTS is unavailable there.

@sluicebox sluicebox requested a review from vyzigold Oct 9, 2019
TTS libraries can now be used in default Mingw-w64 environments.

- Removes reference to sapiddk.h which isn't used and isn't in Mingw-w64
- Defines guids whose symbols are missing from Mingw-w64
- Restores TTS detection to configure script
@sluicebox sluicebox force-pushed the sluicebox:tts-mingww64 branch from 32babd0 to 39d7047 Oct 10, 2019
@bluegr

This comment has been minimized.

Copy link
Member

commented Oct 10, 2019

The changes look good and @vyzigold approved, so this can be merged. Thanks for your work!

@bluegr bluegr merged commit 912bbf3 into scummvm:master Oct 10, 2019
2 checks passed
2 checks passed
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.