Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OPENGL: Implement high DPI support on Android #1895

Merged
merged 2 commits into from Nov 1, 2019

Conversation

@ccawley2011
Copy link
Member

ccawley2011 commented Oct 16, 2019

No description provided.

@tsoliman

This comment has been minimized.

Copy link
Member

tsoliman commented Oct 16, 2019

nitpick: 90 is a magic number that appears in a lot of places
concern: won't this break other ports because handleResize's signature changed?

@antoniou79

This comment has been minimized.

Copy link
Contributor

antoniou79 commented Oct 18, 2019

Thank you for the patch!
I tested on an emulated 1440x2560 (560 dpi) Pixel XL with Android Studio 3.4 and the UI looks quite comfortable if not a bit on the big side.
However, maybe we could implement some options in the Graphics tab, for 2x or 3x etc "scaled" UI, so that the UI won't look so big in devices with smaller resolution.
In particular on all my current physical devices (Xperia Z5 compact, Moto E and Huawei Y550-L01) the Audio tab will display the "Text and Speech" options very shortened and the MIDI and Misc tabs may have options cut out from the UI with no vertical scroll bar.
I think the missing scroll bar in those tabs could be a bug / missing feature, since the Graphics tab gets a vertical scroll bar to properly scroll down to view all the available options.

Copy link
Contributor

antoniou79 left a comment

@ccawley2011 I think this would break the psp2 port due to the following call in psp2sdl-graphics.cpp

	/* Vita display size is always 960x544 (that's just the hardware) */
	handleResize(960, 544);

This would be resolved, if we changed the line to

handleResize(960, 544, 90, 90);

is that correct?
Other than that the PR seems ok to me.

@antoniou79 antoniou79 merged commit 177d709 into scummvm:master Nov 1, 2019
2 checks passed
2 checks passed
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ccawley2011 ccawley2011 deleted the ccawley2011:opengl-dpi branch Nov 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.