Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3DS: NEW FEATURE: Magnify Mode #1909

Closed
wants to merge 11 commits into from

Conversation

@BallM4788
Copy link
Contributor

BallM4788 commented Oct 29, 2019

For games with resolution higher than the hardware resolution, allow toggle-able magnification to and from scale factor 1 on the top screen; use touchscreen to choose what part of the game display to magnify.

@BallM4788 BallM4788 force-pushed the BallM4788:3ds_magnifymode branch from 2d7a4dc to af4e15c Oct 31, 2019
@BallM4788 BallM4788 changed the title 3DS: Add new magnification mode 3DS: NEW FEATURE: Magnify Mode Oct 31, 2019
Copy link
Member

bgK left a comment

Thank you for contribution. This is such a neat idea!

I've requested some changes to optimize / simplify the approach you used. I'll do another round of reviewing and testing afterwards.

backends/platform/3ds/osystem-graphics.cpp Outdated Show resolved Hide resolved
backends/platform/3ds/osystem-graphics.cpp Outdated Show resolved Hide resolved
@BallM4788 BallM4788 requested a review from bgK Nov 2, 2019
@BallM4788

This comment has been minimized.

Copy link
Contributor Author

BallM4788 commented Nov 3, 2019

Well after a bit of bungling up I hope I fixed that conflict with the main branch. To be honest, I'm kind of new to merging and rebasing.

@Mataniko

This comment has been minimized.

Copy link
Contributor

Mataniko commented Nov 3, 2019

Thanks for the update, there is still a little more cleanup left to do, namely the last 4 commits:

You can do this by doing an interactive rebase:
git rebase HEAD~5 -i
In interactive rebase mode, you can either reword, drop or squash (combine with the previous commit) to clean up the commits

edit: There is another commit that needs to be addressed much earlier up, you may want to drop the last commit where you merged master, and use rebase instead there too...

@BallM4788 BallM4788 force-pushed the BallM4788:3ds_magnifymode branch 3 times, most recently from a54fcba to 115aa21 Nov 3, 2019
@BallM4788 BallM4788 force-pushed the BallM4788:3ds_magnifymode branch from 115aa21 to 9d3fb28 Nov 4, 2019
@BallM4788

This comment has been minimized.

Copy link
Contributor Author

BallM4788 commented Nov 4, 2019

Alright, I believe that should be everything.

@bgK

This comment has been minimized.

Copy link
Member

bgK commented Nov 5, 2019

Thanks, merged.

If you want to keep working on this feature, here are some areas of improvement:

  • Automatically enable both screens while magnify mode is enabled.
  • Preventing magnified area updates while the GUI is open.
@bgK bgK closed this Nov 5, 2019
@BallM4788 BallM4788 deleted the BallM4788:3ds_magnifymode branch Nov 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.