Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GUI: Update ScummVM Modern Remastered theme #1912

Open
wants to merge 1 commit into
base: master
from

Conversation

@lotharsm
Copy link
Member

lotharsm commented Nov 1, 2019

A while ago, @Tkachov created a set of custom ScummVM themes.

Since I really like the more "flat" style, I adapted the GFX .stx file for our current ScummVM Modern Remastered theme - and I think it really works well.

Theme-wise, full credit goes to @Tkachov - all I did was to re-color the checkbox and radio buttons so they match our color scheme and changed the formatting of the .stx file so they match our current standard. Otherwise, the theme itself, especially the .stx file, is untouched.

Here are a few screenshots:

scummvm00000
scummvm00001
scummvm00002
scummvm00003
scummvm00004
scummvm00005

So - what do you think? :)

@lotharsm lotharsm requested a review from Tkachov Nov 1, 2019
@Mataniko

This comment has been minimized.

Copy link
Contributor

Mataniko commented Nov 1, 2019

Let me preface that I think that the remastered theme still has a lot of to improve. Things like the scrollbars and buttons are the obvious big places to start.

However, these don't really work on a few levels:

  • Flatness - This is too flat. Even with flat design, modals and buttons have some depth to them, otherwise they blend too much and the interaction becomes awkward. Even worse is now you have elements with some depth, and other elements with no depth, making the theme feel inconsistent
  • Colors - The colors, especially Red on Orange need some work, but the white modals don't work at all, especially with red accents.

What does work:

  • Scrollbars - I think they're an improvement, but would require some more refinement.
Copy link
Contributor

Tkachov left a comment

If I understood correctly, this is basically a recolor of my theme (no layout changes), so I guess it ain't broken. It looks like the default Modern Remastered, though it's easy to notice that white/gray are used instead of pale-yellowish colors that were used before. Might be why it looks a little bit brighter and what @Mataniko is talking about in Colors.

I personally like square-ish tabs/buttons/everything more. But that's the point of custom theme. Is it good enough to be in the default theme? I don't know. It's better to ask everybody else and tune default theme appropriately.

@lotharsm

This comment has been minimized.

Copy link
Member Author

lotharsm commented Nov 2, 2019

Hi there, thanks for your replies - it's a good start for a discussion :)

Flatness - This is too flat. Even with flat design, modals and buttons have some depth to them, otherwise they blend too much and the interaction becomes awkward. Even worse is now you have elements with some depth, and other elements with no depth, making the theme feel inconsistent

Well - I have to admit that I am a huge fan of modern, flat designs - I even tried to play around with completely square buttons ;)

Colors - The colors, especially Red on Orange need some work, but the white modals don't work at all, especially with red accents.

Yeah... it's not easy at all to work with the orange color scheme...

What does work:

Scrollbars - I think they're an improvement, but would require some more refinement.

What do you think should be improved regarding the scrollbars?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.