Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
CLOUD: Remove the saves sync finished OSD message #1916
When using the cloud save sync features, It seems to me there are too many user interface elements, I feel a bit overwhelmed. There is a blinking overlay icon indicating network activity, OSD messages indicating success or failure, and a progress dialog when the save / load dialog is open.
With this PR, I propose removing the OSD message indicating the save sync finished successfully. For me, it breaks the experience when it appears while in-game after the engine autosaved. IMO, the overlay icon disappearing is a good enough indication that the saves synchronized.
I didn't really test the feature by completing the game yet (well, I wanted to do that on Android and there was a problem with certificates), but I thought that OSD message might be a little bit distracting.
I think instead of removing we should add some options for user to specify whether they want to see it or not. Like:
Maybe also add some icon for "failure" and show it for some time on failure. Or even turn that icon in actual interactable element. If you click a "working" icon, it shows some popup with current progress (for the "what takes you so long and when you'll be done?" use-case) and if it's "failed" icon, it shows the reason and maybe some hints on how that could be resolved, maybe "retry" button as well.
I don't really see a case where having the save sync message would really be useful, so I would tend to agree with @bgK that it can be removed entirely rather than adding an option. We don't really want options for every feature that can have one, as we would end up with too many options, as well as unnecessary code that adds to the maintenance burden. And to me it seems that this is a case where we don't really need an option.
Note that this is not a strong opinion. For me the Dropbox notification for every synchronised saved was more disruptive as it was removing the focus from the ScummVM window and causing the system cursor to be displayed in addition to the ScummVM one (until I turned those notifications off). In comparison the OSD message is not as disruptive :-P