Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
TTS: Improve Windows audio, remove sphelper-scummvm.h #1917
This removes sphelper-scummvm.h, a large patched Microsoft SDK header whose inclusion in the codebase raises the typical open source concerns: https://bugs.scummvm.org/ticket/11143.
Personally, I'm just offended that Microsoft ships a header that infects us with IsBadWritePtr().
In the process I found that we're setting the audio quality to SPSF_11kHz8BitMono, which is noticeably poor. I thought it had been my imagination that Windows TTS sounded bad on ScummVM but not my other programs. I don't see why we're setting a format at all. That's an OS setting so I've removed it, which conveniently removes another sphelper dependency, and makes TTS sound good.
The idea sounds good.
I don't develop on Windows and I don't have an opinion on the details of the changes, but I noticed you replaced some