Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENGINE: The Griffon Legend #1918

Merged
merged 168 commits into from Nov 13, 2019

Conversation

@sev-
Copy link
Member

sev- commented Nov 6, 2019

Here is a complete engine for a freeware zelda-like RPG The Griffon Legend.

The original game was written in FreeBASIC by Syn9 as part of some contest and published with the full source code. Then it was rewritten to C and ported to GCW0 by Dmitry Smagin, and this is the code I based this implementation on.

I plan to make the game downloadable from scummvm.org once the engine is merged.

Screenshot 2019-11-06 at 19 24 36

Screenshot 2019-11-06 at 19 25 50

@dmitrysmagin

This comment has been minimized.

Copy link

dmitrysmagin commented Nov 6, 2019

Cool! I didn't know that it was possible to fit this game into the scummvm. Thumbs up!

engines/griffon/draw.cpp Outdated Show resolved Hide resolved
engines/griffon/engine.cpp Outdated Show resolved Hide resolved
engines/griffon/logic.cpp Outdated Show resolved Hide resolved
@sev-

This comment has been minimized.

Copy link
Member

sev- commented on d8cc4ef Nov 8, 2019

What does it fix?

This comment has been minimized.

Copy link
Member Author

Strangerke replied Nov 8, 2019

Without the delay, it's entering too fast the second block and it forces the savegame on the first slot

This comment has been minimized.

Copy link
Member Author

Strangerke replied Nov 8, 2019

Additionally, "curRow == 1" is wrong

@sev-

This comment has been minimized.

Copy link
Member

sev- commented on 007411a Nov 8, 2019

How this lowerlock thing is not equivalent to curRow != 0?

This comment has been minimized.

Copy link
Member Author

Strangerke replied Nov 8, 2019

Hum, I came to the conclusion it was required while debugging, but now I'm wondering if the "} else {" line 607 wasn't the only problem… I have to debug again, but you may be right indeed

sev- added 2 commits Nov 8, 2019
@digitall

This comment has been minimized.

Copy link
Member

digitall commented Nov 9, 2019

@sev- : Couple of minor GCC warnings fixes are in a branch on my fork ... The commit is:
digitall@0fe0889

@sev-

This comment has been minimized.

Copy link
Member Author

sev- commented Nov 10, 2019

@digitall thanks, applied

@sev- sev- force-pushed the sev-:griffon branch from 0393850 to 42454c5 Nov 12, 2019
@sev- sev- force-pushed the sev-:griffon branch from 42454c5 to cf58aef Nov 12, 2019
@sev-

This comment has been minimized.

Copy link
Member Author

sev- commented Nov 13, 2019

Thanks all, merging.

@sev- sev- merged commit 7772850 into scummvm:master Nov 13, 2019
0 of 2 checks passed
0 of 2 checks passed
Codacy/PR Quality Review Not up to standards. This pull request quality could be better.
Details
continuous-integration/travis-ci/pr The Travis CI build failed
Details
@bgK

This comment has been minimized.

Copy link
Member

bgK commented on 7b97437 Nov 13, 2019

It would have been nice if this had been it's own pull request, being a shared component change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.