Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix free/delete inconsistencies in OSystem_Win32::convertEncoding #1919
The current implementation of OSystem_Win32::convertEncoding causes some arrays allocated with
Since I am not even able to compile the code, not being on Windows, I would appreciate if others could review and try this before this is pushed to master.
This commit also removes what appeared to be an unused variable (
I stepped through the changes in both codepaths on Windows with several test inputs and they are both fixed and doing what's intended.
The comment "Win32::unicodeToAnsi ses new to allocate" is missing the "u" and the project's code conventions are for no space in "delete ", which I only know from having just done this =)