Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIN32: Exit when WinSparkle runs installer #1920

merged 1 commit into from Nov 8, 2019


Copy link

sluicebox commented Nov 8, 2019

Currently, when WinSparkle runs the downloaded installer, ScummVM remains open and must be manually exited or else the installer will fail. This is awkward since at this point the installer has focus.

WinSparkle has callbacks to handle this, so now ScummVM will exit as soon as WinSparkle runs the downloaded installer. At this point the user has clicked the Install Update button in the WinSparkle dialog so this isn't surprising behavior.

To test this, set SCUMMVM_VERSION to "2.0.0", or patch the version fields in scummvm.rc, and use the Check Now update button. After 2.1.0 downloads click Install Update.

Trac #10368
@sluicebox sluicebox force-pushed the sluicebox:icannotselfterminate branch from 1a5a488 to 9c6a5db Nov 8, 2019

This comment has been minimized.

Copy link

sev- commented Nov 8, 2019

Nice, thanks!

@sev- sev- merged commit f74f8e3 into scummvm:master Nov 8, 2019
2 checks passed
2 checks passed
Codacy/PR Quality Review Up to standards. A positive pull request.
continuous-integration/travis-ci/pr The Travis CI build passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
2 participants
You can’t perform that action at this time.