Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRYO: Remove dead code #1921

Open
wants to merge 1 commit into
base: master
from

Conversation

@ccawley2011
Copy link
Member

ccawley2011 commented Nov 8, 2019

No description provided.

@bluegr

This comment has been minimized.

Copy link
Member

bluegr commented Nov 10, 2019

The Cryo engine is not complete, so I am not sure if this code is really not necessary, or if it is meant to be used in the future.

@digitall digitall requested a review from Strangerke Nov 14, 2019
@digitall

This comment has been minimized.

Copy link
Member

digitall commented Nov 14, 2019

@bluegr : True, though if the code really is totally dead, it can be removed for now and then recovered from git in future if needed. Looking at this, there is a debug console which was added as example, but not hooked up. This should be removed and then implemented fully... at least to allow the debug levels and flags to be adjusted at runtime if needed, which I could look at doing. Otherwise, the main issue here is the removal of the "dead" sound code. As you say, this is not a fully finished engine, but maybe @Strangerke can shed some light.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.