Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GUI: Use a dialog theme layout for the unknown game dialog #1942

Closed
wants to merge 3 commits into from

Conversation

@bgK
Copy link
Member

bgK commented Nov 16, 2019

No description provided.

@criezy

This comment has been minimized.

Copy link
Member

criezy commented Nov 18, 2019

The change looks good.
One drawback though is that with the current code the width of the buttons get adapted to their label, while this is no longer the case after this change, and at least in French the Copy button is not wide enough to display its label.

@sev-

This comment has been minimized.

Copy link
Member

sev- commented Nov 18, 2019

picture?

@bgK

This comment has been minimized.

Copy link
Member Author

bgK commented Nov 19, 2019

picture?

Before:
scummvm00009

After:
scummvm00010

@sev-

This comment has been minimized.

Copy link
Member

sev- commented Nov 19, 2019

That’s great! Did you check it with 320x200? Is it still useable there?

@bgK

This comment has been minimized.

Copy link
Member Author

bgK commented Nov 19, 2019

That’s great! Did you check it with 320x200? Is it still useable there?

As mentioned by criezy there's an issue where the label of buttons can be cut:
scummvm00013

I haven't looked into it yet.

bgK added 3 commits Dec 28, 2019
Previously it was only possible to specify whether items where aligned
to the start or centered in the cross direction of the layouts. It is
now additionally possible to align the items to the far end of the cross
direction or to resize them to match the size of the layout.

Terminology and behavior are loosely based on CSS's flexbox containers.
Prior to this change, a GUI layout was only affected by the screen size.
Now, a layout can additionally be influenced by the GUI dialog and widgets
that uses it. This capability is leveraged to implement the following
features:

* Layout elements that are not bound to a GUI widget do not take space.
   This means that dialogs where the widgets shown depend on for example
   a feature being enabled at configure time no longer have blank spaces.
* Widgets can define a minimal required size for their contents not to be
   cut. For now this is only used for buttons so their width is always
   sufficient for their caption not to be cut. This mechanism could be
   applied to other widget types in the future.
@bgK bgK mentioned this pull request Dec 28, 2019
@bgK bgK force-pushed the bgK:gui-unknown-game-dialog-layout branch from 7de2e68 to 3ccff4f Dec 28, 2019
@bgK bgK closed this Jan 4, 2020
@bgK

This comment has been minimized.

Copy link
Member Author

bgK commented Jan 4, 2020

Merged manually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.