Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WINTERMUTE: restored commented out stack->pop() #1963

Merged
merged 1 commit into from Dec 2, 2019

Conversation

@lolbot-iichan
Copy link
Contributor

lolbot-iichan commented Dec 1, 2019

Unused variables were cleaned up at
4781116, commenting out a bit too much
code, since stack->pop() has a side effect (popping a value from data
stack).

Unused variables were cleaned up at
4781116, commenting out a bit too much
code, since stack->pop() has a side effect (popping a value from data
stack).
@bluegr

This comment has been minimized.

Copy link
Member

bluegr commented Dec 2, 2019

Nice catch! Merging

@bluegr bluegr merged commit 710f395 into scummvm:master Dec 2, 2019
2 checks passed
2 checks passed
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.