Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MOHAWK: RIVEN: Add keymapper support #1990

Closed
wants to merge 1 commit into from

Conversation

@ccawley2011
Copy link
Member

ccawley2011 commented Dec 30, 2019

No description provided.

@sev-
sev- approved these changes Dec 30, 2019
Copy link
Member

sev- left a comment

Nice!

{ Common::KeyState(Common::KEYCODE_r, 'r', Common::KBD_CTRL), "RMM", _("Return To Main Menu") },
{ Common::KeyState(Common::KEYCODE_p, 'p', Common::KBD_CTRL), "INTV", _("Play Intro Videos") }
Comment on lines +898 to +899

This comment has been minimized.

Copy link
@bgK

bgK Dec 31, 2019

Member

Those two keybindings are only for the demo. Please add them conditionally.


Common::Keymap *const engineKeyMap = new Common::Keymap(kKeymapName);

const Common::KeyActionEntry keyActionEntries[] = {

This comment has been minimized.

Copy link
@bgK

bgK Dec 31, 2019

Member

Missing keybindings are:
Escape => Skip / Open main menu. (25th anniversary edition)
Escape => Skip. (other versions)
Space => Pause.

@bluegr

This comment has been minimized.

Copy link
Member

bluegr commented Jan 12, 2020

Closing in favor of #1999, where the comments mentioned here have been addressed

@bluegr bluegr closed this Jan 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.