Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

COMMON: Refactor the Windows resource classes. #1994

Merged
merged 8 commits into from Jan 11, 2020

Conversation

@ccawley2011
Copy link
Member

ccawley2011 commented Jan 4, 2020

The main change that this PR makes is that the NEResources and PEResources classes now have a common base class, which means that a single code path can be used for both 16-bit and 32-bit executables.

@sev-

This comment has been minimized.

Copy link
Member

sev- commented Jan 4, 2020

I love this improvement. I have no suggestions. It could be merged as-is.

@sev-
sev- approved these changes Jan 4, 2020
@bluegr

This comment has been minimized.

Copy link
Member

bluegr commented Jan 11, 2020

Great work! Merging

@bluegr bluegr merged commit a692905 into scummvm:master Jan 11, 2020
1 of 2 checks passed
1 of 2 checks passed
Codacy/PR Quality Review Not up to standards. This pull request quality could be better.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ccawley2011 ccawley2011 deleted the ccawley2011:winresources branch Jan 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.