Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GOB: Add workaround for incorrect Goblins 3 CD audio track strings #2028

Merged
merged 1 commit into from Feb 2, 2020

Conversation

@lawadr
Copy link
Contributor

lawadr commented Jan 30, 2020

Fix for https://bugs.scummvm.org/ticket/11335

Added the fix directly below an existing precedent for this type of issue.

One potential problem might be if there is a version of the game out there in the wild without this bug, but given the naive approach of the aforementioned precedent and the fact that I can't find any other versions of the game to test it...

@bluegr

This comment has been minimized.

Copy link
Member

bluegr commented Feb 2, 2020

The workaround proposed is done in a similar way as fix done for Fascination (right above this one).

So, this can be merged. Thanks for your work!

@bluegr bluegr merged commit 95c1fa5 into scummvm:master Feb 2, 2020
2 checks passed
2 checks passed
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.