Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KYRA: Add detection for Polish fan translation of kyra1 #2032

Merged
merged 1 commit into from Feb 4, 2020

Conversation

@xeros
Copy link
Contributor

xeros commented Feb 2, 2020

Add checksum of "GEMCUT.PAK" for Polish text translation to kyra1 engine.

@sev-

This comment has been minimized.

Copy link
Member

sev- commented Feb 2, 2020

Thanks, could you please fix the commit log message in accordance with our Commit Guidelines?

@xeros xeros changed the title ENGINE kyra1: detection of Polish fan translation ENGINE kyra1: detect Polish translation Feb 2, 2020
@xeros

This comment has been minimized.

Copy link
Contributor Author

xeros commented Feb 2, 2020

Is it better now?

@lotharsm

This comment has been minimized.

Copy link
Member

lotharsm commented Feb 2, 2020

Please use something along the lines of KYRA: Add detection for Polish fan translation of kyra1 for the commit message. Please note that you should change the commit message itself, not only the PR title.

@raziel-

This comment has been minimized.

Copy link
Contributor

raziel- commented Feb 2, 2020

@xeros

Take a look at the other PR's

Something like this should fit:
KYRA: Add detection for Kyrandia 1 polish fan translation

@xeros xeros changed the title ENGINE kyra1: detect Polish translation KYRA: Add detection for Polish fan translation of kyra1 Feb 2, 2020
@xeros

This comment has been minimized.

Copy link
Contributor Author

xeros commented Feb 2, 2020

Done, thank you.

@lotharsm

This comment has been minimized.

Copy link
Member

lotharsm commented Feb 2, 2020

Please change the commit message itself, not the PR title.

@athrxx

This comment has been minimized.

Copy link
Member

athrxx commented Feb 2, 2020

Have you tested this? Does it work as expected?

Having this detected as English will lead to various strings (including the intro) being displayed in English. Setting it to Polish won't work, since we don't have that language resources. But maybe this fan translation is supposed to be like that anyway?

@xeros

This comment has been minimized.

Copy link
Contributor Author

xeros commented Feb 4, 2020

Yes, I have tested it and played most of game locations on PlayStation Classic, having ScummVM compiled as RetroArch core.

Everything works fine for me, but you're right about having some strings not translated.
Intro dialogs and item names are in English (Polish translation for them is integrated in MAIN.EXE file), but game dialogs & location names, loaded from PAK files are in Polish.

It's a fan translation where translated strings to Polish language are mapped to "ENG" and it's different than official Polish version of Legend of Kyrandia 2: Hand of Fate, where Polish strings are properly mapped as "POL". I've started some work on this version too, but it has to be handled differently due many differences to English version.

Adding checksum for Polish translation for kyra1 engine.
Polish strings there are mapped to "ENG".
@xeros xeros force-pushed the xeros:patch-1 branch from e477925 to 29de9c8 Feb 4, 2020
@xeros

This comment has been minimized.

Copy link
Contributor Author

xeros commented Feb 4, 2020

Commit message corrected.

@sev-

This comment has been minimized.

Copy link
Member

sev- commented Feb 4, 2020

Thanks, merging.

@sev- sev- merged commit feb2794 into scummvm:master Feb 4, 2020
2 checks passed
2 checks passed
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@xeros xeros deleted the xeros:patch-1 branch Feb 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.