Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PINK: Implement save & load in the menubar #2041

Merged
merged 1 commit into from Feb 6, 2020
Merged

Conversation

@henke37
Copy link
Contributor

henke37 commented Feb 5, 2020

Fairly obvious and straightforward implementation.

Seems to expose a bug with the pause logic, scenes don't resume correctly, either freezing entirely or loosing the BGM. #NotMyFault

@bluegr

This comment has been minimized.

Copy link
Member

bluegr commented Feb 6, 2020

Thanks for your work. Could you please add a FIXME regarding the pause logic in the code, so that it won't be forgotten?

…ent menu bar commands.
@henke37 henke37 force-pushed the henke37:pinkSaveLoad branch from 03a5bda to 120830a Feb 6, 2020
@sev-

This comment has been minimized.

Copy link
Member

sev- commented Feb 6, 2020

Thanks, merging.

@sev- sev- merged commit 1ff1cfc into scummvm:master Feb 6, 2020
2 checks passed
2 checks passed
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@henke37 henke37 deleted the henke37:pinkSaveLoad branch Feb 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.