Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GUI: Improve how shaders are handled #2048

Open
wants to merge 3 commits into
base: master
from

Conversation

@ccawley2011
Copy link
Member

ccawley2011 commented Feb 7, 2020

This has not been tested on PS Vita, and has only been tested on desktop with a modified version of SurfaceSdlGraphicsManager. This also doesn't account for users with old config files.

@ccawley2011 ccawley2011 requested a review from rsn8887 Feb 7, 2020
@rsn8887

This comment has been minimized.

Copy link
Contributor

rsn8887 commented Feb 9, 2020

Nice @ccawley2011 ! However, it doesn't compile with --host=psp2, I get:

../scummvm/backends/graphics/psp2sdl/psp2sdl-graphics.cpp: In constructor 'PSP2SdlGraphicsManager::PSP2SdlGraphicsManager(SdlEventSource*, SdlWindow*)':
../scummvm/backends/graphics/psp2sdl/psp2sdl-graphics.cpp:81:2: error: class 'PSP2SdlGraphicsManager' does not have any field named '_currentShader'
  _currentShader(GFX_SHADER_NONE) {
@ccawley2011 ccawley2011 force-pushed the ccawley2011:shaders branch from c59ec4d to d085cb2 Feb 9, 2020
@ccawley2011

This comment has been minimized.

Copy link
Member Author

ccawley2011 commented Feb 9, 2020

The compilation issues have been fixed. I also extended this PR to move the shader code out of SurfaceSdlGraphicsManager, since it shouldn't be needed there any more.

@rsn8887

This comment has been minimized.

Copy link
Contributor

rsn8887 commented Feb 19, 2020

Tested working on Vita, ready to merge!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.