Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
SCI32: fix bug #9752 (for all games) #2053
Some SCI32 games have an issue that the saved games thumbnails is useless because it's hidden
We avoid that by keeping the thumbnail everytime the menu bar is hidden,
This fix is for QfG4 only.
Currently the bug doesn't exist if you save by pressing F5 to save since that doesn't bring up the control panel.
How does this behave if I press F5 to save the game or using the GMM or some other way that doesn't involve the menu bar hide action?
I'm guessing a stale image will be used from when the menu bar was last hidden. That would be actually worse IMO as it is silently broken.
If that's the case, then a better solution might be a script patch for the save game handing script to hide the control panel just before saving (since SCI32 saving in ScummVM seem to be script driven and not like SCI16 which explicitly hides the menu before saving)
I've actually verified that this approach introduces a new bug when saving with F5.
The fact that the thumbnail is silently wrong makes this new bug much worse IMO (the old thumbnail was of the correct viewport state, just with a dialog on it, whereas this one is of the last time you happened to show the menubar)
I've tested this with both the GOG version and the Anthology CD version. Both of these are CD versions.
It's likely that this script patch will work on the standalone CD version.
It might be safer to mark this as a QFG4CD patch rather than a generic QFG4 patch unless you've tested the floppy.
I'm getting concise from commit to commit...
I could have put that line under
However, I would like some SCI expert (@sluicebox ?) to make sure that it's OK.