Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BACKENDS: Add events for additional mouse buttons #2055

Open
wants to merge 2 commits into
base: master
from

Conversation

@ccawley2011
Copy link
Member

ccawley2011 commented Feb 11, 2020

This allows the forward and back mouse buttons to be used by the keymapper. This PR also includes one of the commits from PR #2051 to stop the two PRs from conflicting with each other.

EVENT_CUSTOM_BACKEND_HARDWARE = 28
EVENT_CUSTOM_BACKEND_HARDWARE = 28,

EVENT_X1BUTTONDOWN = 29,

This comment has been minimized.

Copy link
@bgK

bgK Feb 12, 2020

Member

Just reading this enumeration without context, I believe it is hard to understand this is about mouse buttons. Perhaps the naming needs to be adjusted to make it more obvious. Perhaps with a comment explaining X1 and X2 are usually respectively back and forward, to make it easier for backend authors.

This comment has been minimized.

Copy link
@ccawley2011

ccawley2011 Feb 25, 2020

Author Member

OK, done.

@ccawley2011 ccawley2011 force-pushed the ccawley2011:mouse-remap branch from 265a93d to 79b5e7b Feb 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.