Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PINK: Mark stuff const #2061

Merged
merged 4 commits into from Feb 15, 2020
Merged

PINK: Mark stuff const #2061

merged 4 commits into from Feb 15, 2020

Conversation

@henke37
Copy link
Contributor

henke37 commented Feb 13, 2020

Const correctness for a bit of everything in the engine.

Notably InventoryMgr::isPinkOwnsAnyItems is not const, because it has a side effect that will cause a crash if removed.

@henke37 henke37 changed the title Mark things in pink const PINK: Mark stuff const Feb 13, 2020
@sev-

This comment has been minimized.

Copy link
Member

sev- commented Feb 15, 2020

Thanks, merging

@sev- sev- merged commit 9131701 into scummvm:master Feb 15, 2020
2 checks passed
2 checks passed
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.