Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDL: Move detection of the desktop resolution into the SdlWindow class #2191

Merged
merged 1 commit into from May 10, 2020

Conversation

@ccawley2011
Copy link
Member

ccawley2011 commented Apr 16, 2020

This PR unifies the code for detecting the desktop resolution across both ScummVM and ResidualVM, which previously handled it slightly differently. It's also needed by residualvm/residualvm#1624.

@sev-
Copy link
Member

sev- commented Apr 16, 2020

I wonder the same. What is your rationale behind this change?

@ccawley2011 ccawley2011 force-pushed the ccawley2011:getDesktopResolution branch from 844c9f4 to c14375a Apr 16, 2020
@ccawley2011
Copy link
Member Author

ccawley2011 commented May 10, 2020

I wonder the same. What is your rationale behind this change?

I updated the description with a proper explanation.

@sev-
Copy link
Member

sev- commented May 10, 2020

Thanks, now it is clear, merging.

@sev- sev- merged commit 2f6d219 into scummvm:master May 10, 2020
2 checks passed
2 checks passed
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ccawley2011 ccawley2011 deleted the ccawley2011:getDesktopResolution branch May 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.