JANITORIAL: Remove braces for single line if-block #220

Closed
wants to merge 1 commit into
from

Projects

None yet

3 participants

@singron
Contributor
singron commented Mar 29, 2012

@tsoliman suggested I make this change. It's purely cosmetic, relating to my last commit.

Also is this the proper use of this subsystem?

@tsoliman
Member

I thought that subsystem was for global cleanups.
I would have written "SKY: Minor formatting change" or similar. My rationale is that it is that someone doing a bisect or a blame or a log operation would know to skip or disregard.

@digitall
Member

I would agree with tsoliman. Since this only touches the sky engine, SKY: would be the prefix...

This is made clear in:
http://wiki.scummvm.org/index.php/Commit_Guidelines
"JANITORIAL: Cross-subsystem cleanups and formatting changes"

@singron: If you haven't already, you should read this document and the other documentation at:
http://wiki.scummvm.org/index.php/Developer_Central

However, we are not slavish about these rules, we do like the code/commits to be consistent i.e.
http://wiki.scummvm.org/index.php/Code_Formatting_Conventions#Use_common_sense

@digitall
Member

Since this was a very small formatting only fix, it didn't really justify a pull request (and nasty merge commit! ;-). Have made the fix in master, so can close this without merge.

@digitall digitall closed this Mar 30, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment