Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WINTERMUTE: Add new reversion Steam releases #2206

Merged
merged 2 commits into from May 3, 2020
Merged

Conversation

@aviloria
Copy link
Contributor

aviloria commented Apr 26, 2020

Added new reversion1 and reversion3 Steam releases.
Also added support for a new language: Serbian

@somaen
Copy link
Member

somaen commented Apr 26, 2020

Thanks. Something looks odd with the Serbian-language patches, would you mind merging them together into a single patch?

@sev-
Copy link
Member

sev- commented Apr 30, 2020

@aviloria
Copy link
Contributor Author

aviloria commented May 2, 2020

Sorry, I overlooked the message...
What do you mean? Do you want me to isolate Serbian language changes from the new game additions?
What's the problem with the Sebian patch?

@Mataniko
Copy link
Contributor

Mataniko commented May 2, 2020

It looks like your commits are duplicates because some of them have the same commit message.

You don't need to commit one file, or one line at a time, please make all of the relevant changes into 1 commit and update the PR.

@aviloria
Copy link
Contributor Author

aviloria commented May 2, 2020

Sorry about that... I got an error message when pushing from command line... so I guess I mixed web and command-line commands on submission, resulting in a weird batch of commits.
I hope all looks better now

@sev-
Copy link
Member

sev- commented May 3, 2020

Looks fine now besides some small issues with indentations which I will fix after the merge.

@sev- sev- merged commit b86ab4f into scummvm:master May 3, 2020
2 checks passed
2 checks passed
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@aviloria aviloria deleted the aviloria:patch-2 branch May 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.