Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ports: Pause token mk2 #2239

Merged
merged 5 commits into from May 10, 2020
Merged

Ports: Pause token mk2 #2239

merged 5 commits into from May 10, 2020

Conversation

@henke37
Copy link
Contributor

henke37 commented May 10, 2020

Fix some missed uses of Engine::pauseEngine from #2147.

@henke37 henke37 force-pushed the henke37:pauseTokenMk2 branch from 0606438 to 0aff1bd May 10, 2020
@henke37
Copy link
Contributor Author

henke37 commented May 10, 2020

The lifetime of the PauseToken object is significant. The destructor has semantic value, it unpauses the engine once, matching the pausing required to get the token in the first place.

@sev-
Copy link
Member

sev- commented May 10, 2020

Thanks, let's see the buildbot.

@sev- sev- merged commit 8ff38d7 into scummvm:master May 10, 2020
1 of 2 checks passed
1 of 2 checks passed
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.