Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ULTIMA8: More custom type checking cleanup #2251

Merged
merged 2 commits into from May 15, 2020

Conversation

@OMGPizzaGuy
Copy link
Contributor

OMGPizzaGuy commented May 15, 2020

Remove unused IsOfType string-based methods and p_dynamic_cast template function.

Remaining IsOfType methods likely can be replaced with dynamic_cast as well

@OMGPizzaGuy
Copy link
Contributor Author

OMGPizzaGuy commented May 15, 2020

Attempts to simply make IsOfType use dynamic_cast aren't as straightforward as hoped - might need to brush up more on templates

@mduggan
Copy link
Contributor

mduggan commented May 15, 2020

All looks great, thanks!

@mduggan mduggan merged commit 1dcdb0f into scummvm:master May 15, 2020
2 checks passed
2 checks passed
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.