Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ANDROID: Set a default path for PKG_CONFIG_LIBDIR #2252

Merged
merged 2 commits into from May 23, 2020

Conversation

@ccawley2011
Copy link
Member

ccawley2011 commented May 15, 2020

This is useful when building using the docker images from dockerized buildbot separately from the buildbot setup.

@antoniou79 antoniou79 requested a review from lephilousophe May 15, 2020
@lephilousophe
Copy link
Member

lephilousophe commented May 21, 2020

I would expect environment variable to be set from the outside.
But this setting totally makes sense as configuring with --host will automatically set the correct pkg-config path and lighten the prerequisites for the environment.
That's a good idea.

@ccawley2011, @antoniou79: do you think that adding /bin to PATH would be a good thing?
That would let configure find curl-config (our configure script doesn't use pkg-config for libcurl) but that makes us messing with environment one more time (and it's not easy to detect if we need to add the directory or not).

@antoniou79
Copy link
Contributor

antoniou79 commented May 21, 2020

@ccawley2011, @antoniou79: do you think that adding /bin to PATH would be a good thing?
That would let configure find curl-config (our configure script doesn't use pkg-config for libcurl) but that makes us messing with environment one more time (and it's not easy to detect if we need to add the directory or not).

If I understand it correctly, I think it would be a good idea. I have often run into trouble when the wrong binaries get detected, so especially in the cases of dockerized build setups the toolchain binaries should be prioritized in PATH.

@antoniou79 antoniou79 merged commit 9c422f5 into scummvm:master May 23, 2020
2 checks passed
2 checks passed
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ccawley2011 ccawley2011 deleted the ccawley2011:android-pkg-config branch May 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.