Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BASE: Added 'test_new_standards.cpp' #2259

Merged
merged 1 commit into from May 27, 2020
Merged

BASE: Added 'test_new_standards.cpp' #2259

merged 1 commit into from May 27, 2020

Conversation

@ZvikaZ
Copy link
Contributor

ZvikaZ commented May 17, 2020

Adding C++11 compatibility tests, disabled by default.
See instructions inside the file.

base/test_new_standards.cpp Show resolved Hide resolved
#ifndef DONT_TEST_DELETED_FUNCTIONS
// ------------------------
// Explicitly Deleted Functions
// (useful for non copyable classes)

This comment has been minimized.

Copy link
@sev-

sev- May 19, 2020

Member

Particularly for our Singleton class.

@ZvikaZ ZvikaZ force-pushed the ZvikaZ:z_cpp11 branch from d08bf4d to 18d6b3e May 19, 2020
@ZvikaZ ZvikaZ requested a review from sev- May 19, 2020
@henke37
Copy link
Contributor

henke37 commented May 19, 2020

I'm a little surprised that it doesn't test move semantics. Think you can add a test for that?

Adding C++11 compatibility tests, disabled by default.
See instructions inside the file.
@ZvikaZ ZvikaZ force-pushed the ZvikaZ:z_cpp11 branch from 18d6b3e to 9ce6530 May 20, 2020
@ZvikaZ
Copy link
Contributor Author

ZvikaZ commented May 20, 2020

I'm a little surprised that it doesn't test move semantics. Think you can add a test for that?
@henke37 , you got it.

@sev-
Copy link
Member

sev- commented May 27, 2020

Cool, let's see how our ports will behave. Merging.

@sev- sev- merged commit 55ae963 into scummvm:master May 27, 2020
2 checks passed
2 checks passed
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ZvikaZ ZvikaZ deleted the ZvikaZ:z_cpp11 branch May 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.