Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ULITIMA8: Improve basic avatar keyboard movement. #2261

Merged
merged 1 commit into from May 18, 2020

Conversation

@OMGPizzaGuy
Copy link
Contributor

OMGPizzaGuy commented May 17, 2020

ULITIMA8: Improve basic avatar keyboard movement.

This adds continuous movement while the movement keys are depressed. I'm an unsure how Crusader should move, so this was just experimenting until the controls felt good for the Avatar. I'm thinking a few adjustments might be keyboard jumping being a jump forward instead of towards mouse, and maybe shift modifier to run and control modifier to step.

@mduggan
Copy link
Contributor

mduggan commented May 18, 2020

Thanks! I had been meaning to do improvements like this so this is awesome.

This will change them to how they should work in crusader basically - it also uses shift to run btw.

Crusader is a little bit more subtle in that it effectively has a continuous target direction (with a target reticule showing the that direction) and the avatar rotates to face the closest he can.. also avatar has 16 combat frames and 8 walking ones so there's still a bunch of changes to do there, but that's all out of scope here.

For jump key, I feel the "targeted" jump button should go to the mouse cursor ideally, it makes getting through the jumping puzzles a lot less frustrating (and makes them possible on platforms without two mouse buttons). The running jump doesn't work with the jump key at the moment though, and that should just go in current direction.

@mduggan mduggan merged commit 384a175 into scummvm:master May 18, 2020
2 checks passed
2 checks passed
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.