Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SCI: fix bug #11476 (QFG1: Incomplete Music) #2268

Merged
merged 1 commit into from May 23, 2020

Conversation

@athrxx
Copy link
Member

athrxx commented May 22, 2020

This fixes a regression from 3154d57. The fix is based on my findings in the QFG1 DOS disasm (counterchecked a bit with PQ2 DOS disasm).

(regression from  3154d57)
@Deledrius
Copy link
Contributor

Deledrius commented May 23, 2020

I can confirm this fixes the problems I reported in bug #11476.

@bluegr
Copy link
Member

bluegr commented May 23, 2020

Great work, thanks! Merging

@bluegr bluegr merged commit e16ab73 into scummvm:master May 23, 2020
2 checks passed
2 checks passed
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@athrxx athrxx deleted the athrxx:sci-soundfix-11476 branch May 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.