Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WINTERMUTE: Added jamesperis Steam releases #2269

Merged
merged 2 commits into from May 23, 2020

Conversation

@aviloria
Copy link
Contributor

aviloria commented May 22, 2020

Added Steam releases of "James Peris: No License Nor Control - Definitive Edition"

Added Steam releases of "James Peris: No License Nor Control - Definitive Edition"
@lolbot-iichan
Copy link
Contributor

lolbot-iichan commented May 23, 2020

Thanks for adding those! It's cool to see that James Peris is finally at the store, and I somehow missed it.

It seems that Steam 2020-04-27 release has both parche9.dcp and parche91e.dcp packages, which causes double detection as versions Version 1.9 & Version 1.9.1e.

To avoid it, I suggest adding "parche9.dcp", "05363aa13cb8aa5a3fafc68adb4dda5a", 207640138 to Steam 2020-04-27 as well:

	// James Peris: No License Nor Control - Definitive Edition (English) (Steam 2020-04-27)
	WME_WINENTRY("jamesperis", "Version 1.9.1e",
		WME_ENTRY3s("data.dcp", "60568c88c9dc5653bfc94a8cbf228748", 225299678,
					"parche9.dcp", "05363aa13cb8aa5a3fafc68adb4dda5a", 207640138,
					"parche91e.dcp", "ee21819363fb32a38b9f5fcf8545e374", 72496832), Common::EN_ANY, ADGF_UNSTABLE, WME_1_9_3),

	// James Peris: No License Nor Control - Definitive Edition (Spanish) (Steam 2020-04-27)
	WME_WINENTRY("jamesperis", "Version 1.9.1e",
		WME_ENTRY3s("data.dcp", "60568c88c9dc5653bfc94a8cbf228748", 225299678,
					"parche9.dcp", "05363aa13cb8aa5a3fafc68adb4dda5a", 207640138,
					"parche91e.dcp", "ee21819363fb32a38b9f5fcf8545e374", 72496832), Common::ES_ESP, ADGF_UNSTABLE, WME_1_9_3),
@lolbot-iichan lolbot-iichan self-requested a review May 23, 2020
Fixed double detection of jamesperis v1.9.1e
@lolbot-iichan lolbot-iichan merged commit 8ef5e11 into scummvm:master May 23, 2020
2 checks passed
2 checks passed
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@lolbot-iichan
Copy link
Contributor

lolbot-iichan commented May 23, 2020

Thanks, merging!

@aviloria aviloria deleted the aviloria:patch-1 branch May 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.