Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CREATE-PROJECT: Set MSVC subsystem #2405

Merged
merged 3 commits into from Nov 12, 2020
Merged

Conversation

@henke37
Copy link
Contributor

@henke37 henke37 commented Aug 13, 2020

There is no need to show an unusable console window, so only show that if the text console is enabled.

@henke37 henke37 force-pushed the henke37:subsystemBuild branch from dd44bde to 38ff366 Aug 13, 2020
@henke37 henke37 force-pushed the henke37:subsystemBuild branch from eb4e199 to eb670bd Aug 21, 2020
@bluegr
Copy link
Member

@bluegr bluegr commented Aug 30, 2020

Nice work! A good and easy way to manage the console

@SupSuper
Copy link
Contributor

@SupSuper SupSuper commented Aug 30, 2020

Upon further examination, the text-console parameter is kinda deceptive. The full name is USE_TEXT_CONSOLE_FOR_DEBUGGER.
Personally I like having the text console for debug output but not as a debugger, so I'd prefer if the two weren't tied together.

@henke37 henke37 force-pushed the henke37:subsystemBuild branch from eb670bd to 4e80f96 Oct 2, 2020
@sev-
Copy link
Member

@sev- sev- commented Oct 4, 2020

What is the status of this PR?

@henke37
Copy link
Contributor Author

@henke37 henke37 commented Oct 4, 2020

As far as I know, ready to merge unless someone has an objection.

@henke37 henke37 force-pushed the henke37:subsystemBuild branch from 4e80f96 to 3acd0a7 Oct 10, 2020
@henke37 henke37 force-pushed the henke37:subsystemBuild branch from 3acd0a7 to 57bb3d7 Oct 19, 2020
@henke37 henke37 force-pushed the henke37:subsystemBuild branch from 57bb3d7 to 497778a Nov 3, 2020
@henke37 henke37 force-pushed the henke37:subsystemBuild branch from 497778a to f9eba18 Nov 11, 2020
@deepcode-ci-bot
Copy link

@deepcode-ci-bot deepcode-ci-bot bot commented Nov 11, 2020

Congratulations 🎉. DeepCode analyzed your code in 495.537 seconds and we found no issues. Enjoy a moment of no bugs ☀️.

👉 View analysis in DeepCode’s Dashboard | Configure the bot

@dreammaster
Copy link
Member

@dreammaster dreammaster commented Nov 11, 2020

I previously overlooked this pull request. Since I'm at work right now and can't test it, and I'm a bit confused about "text window" vs "console window" in the description. Does this mean that builds done in MSVC won't have the console window open by default?

@henke37
Copy link
Contributor Author

@henke37 henke37 commented Nov 11, 2020

That's the idea yes, if the os level console isn't used, don't show it.

@dreammaster
Copy link
Member

@dreammaster dreammaster commented Nov 11, 2020

I've no objection then. As long as it's been tested, a merge is fine by me

@henke37
Copy link
Contributor Author

@henke37 henke37 commented Nov 11, 2020

I've been using it for my builds for like half a year now.

@SupSuper SupSuper merged commit 1079a0f into scummvm:master Nov 12, 2020
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
deepcode-ci-bot Well done, no issues found!
Details
@henke37 henke37 deleted the henke37:subsystemBuild branch Nov 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.