Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TESTBED: Test networking #2427

Merged
merged 1 commit into from Sep 12, 2020
Merged

TESTBED: Test networking #2427

merged 1 commit into from Sep 12, 2020

Conversation

@henke37
Copy link
Contributor

henke37 commented Aug 26, 2020

There seems to be a need for a test suite for non webserver related networking functionality.

To start off it checks if the OSystem::isConnectionLimited member function works.

@henke37 henke37 force-pushed the henke37:netTest branch from 677249e to 58a52b5 Aug 26, 2020
@henke37 henke37 force-pushed the henke37:netTest branch from 58a52b5 to 18831f9 Aug 27, 2020
@henke37 henke37 force-pushed the henke37:netTest branch from 18831f9 to 1a7a1d4 Aug 28, 2020
Copy link
Member

criezy left a comment

Thank you. Having network tests could indeed be useful. I just have one minor comment on a comment that seems out of place. Otherwise it looks good.

Do you have other network tests in mind that would make sense to add?

bool isLimited = g_system->isConnectionLimited();

if (ConfParams.isSessionInteractive()) {
// Directly verify date

This comment has been minimized.

@criezy

criezy Sep 7, 2020 Member

Is that a copy/paste from another test? This comment doesn't seem to make much sense here ;-)

This comment has been minimized.

@sev-

sev- Sep 12, 2020 Member

I'll clean it up after the merge.

@sev-
Copy link
Member

sev- commented Sep 12, 2020

Thank you! Hope you will have time/enthusiasm for implementing deeper tests. Merging.

@sev- sev- merged commit ec1ebfa into scummvm:master Sep 12, 2020
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
deepcode-ci-bot Well done, no issues found!
Details
@henke37
Copy link
Contributor Author

henke37 commented Sep 12, 2020

I have been meaning to clean it up myself, but thanks.

As for more tests, I was thinking of at least pilfering the get ip test from the webserver group. Bit tricky when the underlying code there is part of the webserver code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.