Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use native language names #2436

Merged
merged 3 commits into from Sep 2, 2020
Merged

Use native language names #2436

merged 3 commits into from Sep 2, 2020

Conversation

@criezy
Copy link
Member

criezy commented Aug 30, 2020

Now that the GUI uses UTF-32, we no longer need to restrict language names to ASCII characters. This means we can use accentuated characters and non-latin alphabets.

This pull request proposes to do that.
Possible issues:

  • I pulled the language names from the wikipedia language selection menu. Hopefully this is correct, but it would be good to check.
  • I only implemented a basic sorting of U32String based on the character values. This is not ideal, so if somebody wants to implement proper unicode string sorting, that would be welcome. But I considered that it was overkill just for a language selection menu. I only considered doing the sorting based on the language code, but this is not ideal either (for example we end up having Suomi between Euskara and Français).

image

criezy added 3 commits Aug 30, 2020
Those operators just compare the numerical value of each character
one by one. This is not idea, but this is better than nothing.
We can now use non-ASCII characters in language names, so add
missing acccent and use native alphabet.
@ZvikaZ
Copy link
Contributor

ZvikaZ commented Aug 30, 2020

That's a good idea, IMO. And I've verified that Hebrew is indeed spelled correctly.

@jepael
Copy link
Contributor

jepael commented Aug 31, 2020

I confirm Suomi and Svenska are written correctly.

@bluegr
Copy link
Member

bluegr commented Aug 31, 2020

I confirm that Greek is written correctly.

I also propose to merge this, if there are any typos they can be fixed later on.

@Kawa-oneechan
Copy link
Contributor

Kawa-oneechan commented Aug 31, 2020

Nederlands klopt.

@sev-
Copy link
Member

sev- commented Aug 31, 2020

I was looking for this for so long... finally we can do it.

@raziel-
Copy link
Contributor

raziel- commented Sep 1, 2020

Deutsch ist korrekt.

Hehehe :-D

@SupSuper
Copy link
Contributor

SupSuper commented Sep 1, 2020

Português looks good to me!

@lotharsm
Copy link
Member

lotharsm commented Sep 2, 2020

Español, Català, Galega and Euskara are correct too.

@sev-
Copy link
Member

sev- commented Sep 2, 2020

Let me just finish this :P. BTW, Belarussian, Ukrainian, Russian and Polish are all correct.

@sev- sev- merged commit 7851cab into scummvm:master Sep 2, 2020
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
deepcode-ci-bot Well done, no issues found!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

9 participants
You can’t perform that action at this time.