Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC] Prefer in-memory SoundFont data over global setting in FluidSynth driver #2441

Merged
merged 1 commit into from Sep 2, 2020

Conversation

@eriktorbjorn
Copy link
Member

eriktorbjorn commented Sep 2, 2020

Blazing Dragons provides a custom SoundFont to the FluidSynth driver. Unfortunately, I can't find any sensible way to use that because my global SoundFont setting takes precedence over the in-memory data. Even overriding the MIDI settings for Blazing Dragons and leaving the SoundFont setting blank did not help.

What I've tried to do here is to soften the check so that FluidSynth will prefer in-memory data unless a SoundFont has been explicitly configured for the current game.

Does this seem like a sensible solution? If so, should it also go into the 2.2 branch?

When an engine provides in-memory SoundFont data, use that unless a
SoundFont has been explicitly configured on the current game. Otherwise
a global SoundFont setting will always override it. Even overriding the
MIDI settings for the game and leaving the SoundFont setting blank did
not work for me.
@sev-
Copy link
Member

sev- commented Sep 2, 2020

Yes, it makes sense. Merging

@sev- sev- merged commit 58a77ab into scummvm:master Sep 2, 2020
5 checks passed
5 checks passed
Windows (win32, x86-windows, x86, --enable-faad --enable-mpeg2 --disable-fribidi, curl faad2 flui...
Details
Windows (x64, x64, x64-windows, --enable-faad --enable-mpeg2 --disable-fribidi, curl faad2 fluids...
Details
Windows (arm64, arm64, arm64-windows, --enable-faad --enable-mpeg2 --disable-fribidi, curl faad2 ...
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
deepcode-ci-bot Well done, no issues found!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.