Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IPHONE/IOS7: Make use of ModularMutexBackend #2445

Open
wants to merge 2 commits into
base: master
from

Conversation

@ccawley2011
Copy link
Member

ccawley2011 commented Sep 4, 2020

This has not been tested, but it should help to reduce code duplication and make future refactoring simpler.

@criezy
Copy link
Member

criezy commented Sep 6, 2020

Thank you. The change looks good.

The only difference between using the PthreadMutexManager and the current code is that the curent code uses malloc/free to allocate and deallocate the mutex and the PthreadMutexManager uses new/delete, and I don't see how that could break things. But I will give this a spin anyway before merging just to make sure it works.

Copy link
Member

criezy left a comment

These changes break the compilation with Xcode because the pthread-mutex files are not included in the solution by create_project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.