Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Symbian: fix incorrect return type in SymbianActions::actionName(). #2456

Merged
merged 1 commit into from Sep 11, 2020

Conversation

@fedor4ever
Copy link
Contributor

fedor4ever commented Sep 11, 2020

Symbian: silence more warnings from SDK headers.
Symbian: add new project files.

Symbian: silence more warnings from SDK headers.
Symbian: add new project files.
@sev- sev- merged commit 80c29d1 into scummvm:master Sep 11, 2020
5 checks passed
5 checks passed
Windows (win32, x86-windows, x86, --enable-faad --enable-mpeg2 --enable-discord --disable-fribidi...
Details
Windows (x64, x64, x64-windows, --enable-faad --enable-mpeg2 --enable-discord --disable-fribidi, ...
Details
Windows (arm64, arm64, arm64-windows, --enable-faad --enable-mpeg2 --enable-discord --disable-fri...
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
deepcode-ci-bot Well done, no issues found!
Details
@sev-
Copy link
Member

sev- commented Sep 11, 2020

Thanks, however, I cannot backport it to branch-2-2, could you please provide a patch for that branch?

Also, it would be nice to follow to our git log guidelines.

@sev-
Copy link
Member

sev- commented Sep 11, 2020

Actually, I resolved the conflict but please check that the branch-2-2 compiles well.

@fedor4ever
Copy link
Contributor Author

fedor4ever commented Sep 12, 2020

Thanks, however, I cannot backport it to branch-2-2, could you please provide a patch for that branch?
Where send this patch?
Also, it would be nice to follow to our git log guidelines.
Ok.

@sev-
Copy link
Member

sev- commented Sep 12, 2020

As I've explained in my following comment, I've backported your change to branch-2-2, but I obviously cannot test it.

Could you please test that branch-2-2 compiles and is ready for the release for you?

@fedor4ever
Copy link
Contributor Author

fedor4ever commented Sep 12, 2020

I'm building engines now. Still. I hope build them today. That need a lot time because several engines build too long. Ultima engine builds over 40 mins. It will be good to build engines as static libs at CI server to test if something wrong.

@sev-
Copy link
Member

sev- commented Sep 12, 2020

Did you try parallel builds? Like make -j6 for a 4 CPU machine.

@fedor4ever
Copy link
Contributor Author

fedor4ever commented Sep 13, 2020

Short answer - it's impossible.

Symbian SDK comes with own build system named abld build system. It written in artificial perl 5.6 and over 20 years old. Paralell builds lol.
There are many perl scripts. Several related to abld build.

I wrote python script to dump .mmp(symbian project files) and wish to store as ninja project files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.