Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SCI: PQ4 - Partial fix for #11660 (keep speech and subtitles setting) #2463

Open
wants to merge 1 commit into
base: master
from

Conversation

@ZvikaZ
Copy link
Contributor

ZvikaZ commented Sep 14, 2020

Issue #11660 is caused by signTalker overriding global90,
which keeps speech and subtitles settings.
That's fixed in this patch.

Similar problem can also be caused by computerTalker.
Waiting to see it happening, before fixing.

@ZvikaZ
Copy link
Contributor Author

ZvikaZ commented Sep 14, 2020

Note: in this patch I assumed that global190 isn't used (because grep didn't find any use of it, beside its declaration in main).
I'd be glad if someone can verify me.

@ZvikaZ ZvikaZ changed the title SCI: Partial fix for #11660 (keep speech and subtitles setting) SCI: PQ4 - Partial fix for #11660 (keep speech and subtitles setting) Sep 14, 2020
Issue #11660 is caused by signTalker overriding global90,
which keeps speech and subtitles settings.
That's fixed in this patch.

Similar problem can also be caused by computerTalker.
Waiting to see it happening, before fixing.
@ZvikaZ ZvikaZ force-pushed the ZvikaZ:z_pq4_11660_a branch from 31e5db6 to 94aba39 Sep 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
You can’t perform that action at this time.