Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BACKENDS: Add a function to return if the overlay is visible #2464

Merged
merged 1 commit into from Sep 14, 2020

Conversation

@ccawley2011
Copy link
Member

ccawley2011 commented Sep 14, 2020

Only the SDL and OpenGL graphics managers have been tested so far.

@sev-
Copy link
Member

sev- commented Sep 14, 2020

Could you please provide a use case for this functionality?

@ccawley2011
Copy link
Member Author

ccawley2011 commented Sep 14, 2020

A potential use case for this is mentioned in #2462 (comment)

@rsn8887
Copy link
Contributor

rsn8887 commented Sep 14, 2020

I would love this to be merged, so I can make PR #2462 much more elegant, it would only need a single line of code change, but needs this PR to be merged prior.

@sev-
Copy link
Member

sev- commented Sep 14, 2020

Thanks, merging.

@sev- sev- merged commit 31be074 into scummvm:master Sep 14, 2020
5 checks passed
5 checks passed
Windows (win32, x86-windows, x86, --enable-faad --enable-mpeg2 --enable-discord --disable-fribidi...
Details
Windows (x64, x64, x64-windows, --enable-faad --enable-mpeg2 --enable-discord --disable-fribidi, ...
Details
Windows (arm64, arm64, arm64-windows, --enable-faad --enable-mpeg2 --enable-discord --disable-fri...
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
deepcode-ci-bot Well done, no issues found!
Details
@ccawley2011 ccawley2011 deleted the ccawley2011:isOverlayVisible branch Sep 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.