Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GUI: Update "edit game" for new graphics options (please test before merge!) #2512

merged 1 commit into from Oct 12, 2020


Copy link

@eriktorbjorn eriktorbjorn commented Oct 11, 2020

The new graphics settings (I assume they were added in the ResidualVM merge) are always active in "edit game", even if we're not overriding the global settings. This attempts to fix that.

I'm not sure if I got it all right, and the "V-Sync" checkbox is a bit unusual in that this setting is true by default. But it's a start.

Make the new graphics options in "edit game" disabled until the user
asks to override the global settings. (Most of these were added during
the ScummVM/ResidualVM merger, I guess.)
Copy link

@aquadran aquadran commented Oct 12, 2020

tested, looks ok

@aquadran aquadran merged commit 9acdbe4 into scummvm:master Oct 12, 2020
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
deepcode-ci-bot Well done, no issues found!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.