Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
CONFIGURE: Also install shaders if gles2 enabled #2513
Since the commit "CONFIGURE: Do not enable opengl_shaders feature flag for gles2. " (b3ffd89), the shaders are no more installed for opengles2 systems.
I don't know if my way to test "USE_OPENGL_SHADERS or USE_GLES2" in Makefile is the standard of ScummVM but it works.
Looking at this more, wouldn't this make more sense to be handled in
Sort of keeping USE_OPENGL_SHADERS as the condition in the makefile but setting
Basically revert the changes in the
something like this:
This is a lot more clear and follows the intention better.
(Note: This will obviously break if someone configures with --enable-opengles2 and --disable-opengl-shaders but I think that's ok and a good thing. It's certainly better than silently enabling shaders when explicitly requesting disabling shaders)