Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GRAPHICS: Problem with virtual mouse position in an overlay when full… #2536

Merged
merged 1 commit into from Oct 17, 2020

Conversation

@lmerckx
Copy link
Contributor

@lmerckx lmerckx commented Oct 17, 2020

There is a problem with the virtual mouse position when game is in an overlay (menu, warning message) in fullscreen mode (for OPENGL, OPENGLES):
The cursor moves far too fast and stays stuck at the bottom-right corner.

It is due to the fact that coordinates are converted as it was still in game.
So a test "!overlayVisible" must be added, as it is done in the reverse method (transformMouseCoordinates).

…screen (OPENGL/OPENGLES).
@aquadran
Copy link
Member

@aquadran aquadran commented Oct 17, 2020

what case do you refer? game, system, etc. I don't see any problem on my side

@lmerckx
Copy link
Contributor Author

@lmerckx lmerckx commented Oct 17, 2020

Occurs on my side:

  • When emulating mouse with joystick
  • In fullscreen mode, with OPENGL and OPENGLES
  • On x64 (Ubuntu) and Raspberry
  • When overlay is open (ScummVM menu, warning message)
  • on ResidualVM games (GRIM, EMI)
@aquadran aquadran merged commit 9a35674 into scummvm:master Oct 17, 2020
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
deepcode-ci-bot Well done, no issues found!
Details
@aquadran
Copy link
Member

@aquadran aquadran commented Oct 17, 2020

ok, I got repro too. fix helps, merging

@lmerckx lmerckx deleted the lmerckx:virt-mous-pos branch Oct 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.