Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KYRA: Add support for unofficial Russian LoK CD release #2538

Closed
wants to merge 6 commits into from

Conversation

@dgladkov
Copy link
Contributor

@dgladkov dgladkov commented Oct 17, 2020

Support the same fan-made Russian translation that was ported to a CD version the game. Also includes original engine data translations for the UI components that were not present for the Floppy release.

  • Verified that both translated subtitles and original English audio work as expected.
  • Verified that all menu items are translated correctly and work as expected.
  • Tested playthrough of roughly 1/3 of the game without any issues.
  • Backport translation and translation fixes back to floppy release and verified it works as expected.
  • Added intro subtitles for Russian Floppy and CD intro images since neither are translated.
@athrxx
Copy link
Member

@athrxx athrxx commented Oct 17, 2020

Very nice. Usually these types of Kyra PRs leave half the work for me to do myself, but in this case it really seems like everything has been done already :-)
I've checked that nothing got broken and the provided kyra.dat file is sane (when I regenerate it myself I don't get any diff).
I can't check the Russian version myself, but since you said you've done that this is basically good to go.

Is it intended that there is no translation for the "Very clever! But your feeble efforts are futile." string?

@dgladkov
Copy link
Contributor Author

@dgladkov dgladkov commented Oct 17, 2020

Is it intended that there is no translation for the "Very clever! But your feeble efforts are futile." string?

This string was not translated in the floppy translation either, but good suggestion - added my translation. Do you think it's also worth backporting my translation improvements back to the source floppy engine-data?

So far the only non-translated strings left are:

	"Malcolm the Jester has broken free!",
	"He now controls the Kyragem...",
	"...source of all magic in Kyrandia!",

These are subtitles for the narration over the first intro sequence (Kyrandia landscape with DESTRUCT.WSA explosions on top), but I can't see those subtitles with neither Floppy En/Ru nor CD En/Ru of the game. Is this something we still need to implement?

@athrxx
Copy link
Member

@athrxx athrxx commented Oct 17, 2020

Thanks for that addition. And yes, the translation for the "very clever" string would probably make sense for the floppy version, too.

AFAIK, the other three untranslated strings ("Malcolm the Jester has broken free" etc.) only get used as subtitles for the TEXT_ENG.CPS in the Japanese version, since that version doesn't have a translated TEXT_ENG.CPS. For all other languages the bitmap seems to have translated text, so the subtitles aren't neeeded (any actually can't get displayed). I assume that the TEXT_RUS.CPS is also translated (or why else would they rename it to "_RUS")? So you can probably leave these strings as they are..

@dgladkov
Copy link
Contributor Author

@dgladkov dgladkov commented Oct 17, 2020

@athrxx
Copy link
Member

@athrxx athrxx commented Oct 17, 2020

Sure, I am open to that suggestion, since it is an unofficial version anyway. You can see how it is done for Japanese in KyraEngine_LoK::seq_introStory() (sequences_lok.cpp). The FM-Towns version uses the normal intro strings table, the PC-98 version has a separate array for it. It looks like a hack, but this is actually from the official release :-)

It is probably less of a hassle to do it like FM-Towns (with the normal strings array). Also, I faintly remember (it is been ~12 years that I added Kyra FM-Towns text) that there isn't too much space left at the bottom. So maybe you'll have to stuff the text into two lines... You'd just need to try it out.

If you rather want to skip that task and just have me merge this PR (which is totally fine) I'll do that, too.

dgladkov added 2 commits Oct 18, 2020
@dgladkov
Copy link
Contributor Author

@dgladkov dgladkov commented Oct 18, 2020

It is probably less of a hassle to do it like FM-Towns

That's what I did, looks like _seq_textsTable [18-20] are reserved for intro story subtitles for all editions but are unused, so we're good. I also found a bug that led us to not using the last line of the intro subtitle stored into _seq_textsTable. Here's the illustration

Before the fix
old

After the fix
new

@dgladkov
Copy link
Contributor Author

@dgladkov dgladkov commented Oct 18, 2020

And Russian translation for completeness
russian

LMK if posting screenshots is discouraged so I can take them down, but this sounds like fair use since I own all Kyrandia games on GoG.

@dgladkov
Copy link
Contributor Author

@dgladkov dgladkov commented Oct 18, 2020

Sorry for the noise, but I just found a high quality Russian translation (image assets are localized & text translation is much closer to the original) of LoK that is a much better candidate for Russian CD support. Closing this PR in favor of #2544

@dgladkov dgladkov closed this Oct 18, 2020
@dgladkov dgladkov deleted the dgladkov:cd_russian branch Oct 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.