Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KYRA: Support Russian LoK translation by Siberian GRemlin #2544

Merged
merged 3 commits into from Oct 18, 2020

Conversation

@dgladkov
Copy link
Contributor

@dgladkov dgladkov commented Oct 18, 2020

Siberian GRemlin implemented a modern and fairly recent (last update 2017) translation of the LoK CD edition , which includes full translation of the image assets.

  • Verified that both translated subtitles and original English audio work as expected.
  • Verified that all menu items are translated correctly and work as expected.
  • Tested playthrough of roughly 1/3 of the game without any issues.
  • Translation is marked as fan to force subtitles by default.
@athrxx
Copy link
Member

@athrxx athrxx commented Oct 18, 2020

Okay, this one is a bit easier than the other one :-)

Normally, the talkie versions don't show the story screen if only speech is enabled and subtitles are disabled. For the Italian fan translation it seems that the story screen is always displayed (probably because the spoken language is still English). See sequences_lok.cpp, lines 250-251. Do you want it like that for Russian? I leave it up to you...

@dgladkov
Copy link
Contributor Author

@dgladkov dgladkov commented Oct 18, 2020

This is a very good suggestion, but I feel it's not enough as the game still starts with subtitles off by default and first time players are going to miss the subtitles in subsequent into scenes. However looks like there's already the code that fixes both problems perfectly:

if (_flags.fanLang != Common::UNK_LANG) {
// HACK/WORKAROUND: Since we can't use registerDefault here to overwrite
// the global subtitles settings, we're using this hack to enable subtitles
// for fan translations
const Common::ConfigManager::Domain *cur = ConfMan.getActiveDomain();
if (!cur || (cur && cur->getVal("subtitles").empty()))
ConfMan.setBool("subtitles", true);
}

I ended up marking Russian translation as fan translation to force subtitles and left story screen logic as it was since players will leave subtitles on anyway.

@dgladkov
Copy link
Contributor Author

@dgladkov dgladkov commented Oct 18, 2020

At this point, I'm OK with merging this PR unless there are comments or objections. Thanks for reviews and helpful tips, @athrxx, much appreciated:)

@athrxx
Copy link
Member

@athrxx athrxx commented Oct 18, 2020

Thanks for your work on this :-)

@athrxx athrxx merged commit 11368b7 into scummvm:master Oct 18, 2020
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
deepcode-ci-bot Well done, no issues found!
Details
athrxx added a commit that referenced this pull request Oct 18, 2020
* KYRA: Support Russian LoK translation by Siberian Gremlin

* Mention source of engine data translation

* Mark Russian CD as fan translation to force subtitles
@dgladkov dgladkov deleted the dgladkov:siberian_gremlin branch Oct 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.